Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Change feedback form to actionable questions #841

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

harshsbhat
Copy link

What kind of change does this PR introduce?

Improves the feedback form by adding actionable responses with options YES and NO rather than asking for a descriptive feedback.

Issue Number:

Screenshots/videos:

image

Summary

@harshsbhat harshsbhat requested a review from a team as a code owner August 2, 2024 16:18
Copy link

github-actions bot commented Aug 2, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview c060079

@DarhkVoyd
Copy link
Member

Hi @harshsbhat . The CI/CD workflow failed here: https://github.com/json-schema-org/website/actions/runs/10218752435/job/28275614951?pr=841
Can you please check it?

@DarhkVoyd
Copy link
Member

Also, the linked issue is tagged GSoD, so most probably it's part of an existing project board plan/epic. Please ensure that the work to be done is agreed upon and you are assigned the issue/ you have checked with the web team to work on an issue before creating a PR, as mentioned here

@harshsbhat
Copy link
Author

I am not very sure what is causing that error. Can you help me? I don't think it is from the file that I have edited

@harshsbhat
Copy link
Author

Also, the linked issue is tagged GSoD, so most probably it's part of an existing project board plan/epic. Please ensure that the work to be done is agreed upon and you are assigned the issue/ you have checked with the web team to work on an issue before creating a PR, as mentioned here

Okay my bad. I won't start to work on something again without the APPROVAL/ASSIGNMENT for the same. So you want me to keep this PR or archive it?

@harshsbhat
Copy link
Author

Also, the linked issue is tagged GSoD, so most probably it's part of an existing project board plan/epic. Please ensure that the work to be done is agreed upon and you are assigned the issue/ you have checked with the web team to work on an issue before creating a PR, as mentioned here

Okay my bad. I won't start to work on something again without the APPROVAL/ASSIGNMENT for the same. So you want me to keep this PR or archive it?

@DarhkVoyd

@DarhkVoyd
Copy link
Member

Also, the linked issue is tagged GSoD, so most probably it's part of an existing project board plan/epic. Please ensure that the work to be done is agreed upon and you are assigned the issue/ you have checked with the web team to work on an issue before creating a PR, as mentioned here

Okay my bad. I won't start to work on something again without the APPROVAL/ASSIGNMENT for the same. So you want me to keep this PR or archive it?

No worries, Harsh. Let's keep this PR for now. Someone from the web team will review it and provide guidance on how to proceed.

@aialok
Copy link
Collaborator

aialok commented Aug 2, 2024

I am not very sure what is causing that error. Can you help me? I don't think it is from the file that I have edited

Basically, the Codecov coverage token is not set up correctly, which is causing the job to fail. You don't need to do anything; the error is in the workflow configuration itself.

@harshsbhat
Copy link
Author

I am not very sure what is causing that error. Can you help me? I don't think it is from the file that I have edited

Basically, the Codecov coverage token is not set up correctly, which is causing the job to fail. You don't need to do anything; the error is in the workflow configuration itself.

Thanks a lot Alok for helping me out!

Copy link
Member

@gregsdennis gregsdennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the issue you grabbed this work from, this change needs to incorporate #762, but it doesn't appear to.

The thing is, we haven't made a decision on the direction for both of these issues together. We need to finalize that decision before work should be done.

To be specific, I don't think it's clear that "submit feedback" means they won't/can't be contacted about their feedback, while "create issue" means "I want to continue this conversation"/"I want more help".

@benjagm
Copy link
Collaborator

benjagm commented Aug 7, 2024

Hi everyone. After losing the Postman accounts we have lost access to the airtable used to store the data. Moving forward we decided to use google sheets instead and we still need to implement the change. Can we hold this change until we are able to store the data again?

@benjagm
Copy link
Collaborator

benjagm commented Sep 23, 2024

@harshsbhat still available to work on this issue? We finally fixed the current feedback component to store data again so we can resume the work here and continue with the changes suggested on #762 . Happy to have a chat and work together on this.

@harshsbhat
Copy link
Author

harshsbhat commented Sep 26, 2024

@benjagm
yeah sure. I will take a look at this tomorrow and ask some doubts if any. 😊

@DhairyaMajmudar
Copy link
Member

Hi, @harshsbhat it seems like tests are failing and some merge conflicts are there can you pls. fix them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[📝 Docs]: Change feedback form to actionable questions
6 participants